fix: avoid focusing booted iOS simulators#790
Merged
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid stealing macOS focus when an iOS simulator is already booted and a daemon open command prepares or reuses a session.
Before: daemon open preparation always requested focusExisting, so follow-up commands could foreground Simulator or Device Hub.
After: open preparation only ensures device readiness; the existing cold-boot path still foregrounds the simulator when it is opened from scratch.
Touched 3 files. Scope stayed in daemon open preparation and regression coverage.
Validation
Targeted daemon regression tests pass: ./node_modules/.bin/vitest run src/daemon/tests/request-router-open.test.ts src/daemon/handlers/tests/session.test.ts.
Static checks pass: pnpm check:quick. Formatting was applied with ./node_modules/.bin/oxfmt --write and git diff --check is clean.
pnpm check:unit was attempted after network escalation for pnpm verification, but failed in unrelated Android/iOS platform tests with 14 mocked command timeouts/failures; the touched daemon tests passed separately.